René Föhring

Results 126 comments of René Föhring

Thank your for this bug report. A cursory analysis yielded no obvious performance flaws in the check itself. Maybe it is just a slow check (we have to collect all...

Great :+1: Since the Elixir website & documentation call this the "final condition", we should name this `CondFinalCondition`. Also, I do think the `true` should be a config parameter for...

> I have added assertions to the tests for this check to verify that the clause expression that triggers issue is what is set for the issue's trigger parameter. This...

This sounds like a bug. Thx for reporting! :+1:

Thanks for reporting this 😀 It is now fixed on `master`. You can try this by setting the Credo dep to ```elixir {:credo, github: "rrrene/credo"} ``` Please report back if...

First, thank you very much for putting this together. As I wrote on Twitter, it would be amazing to have this! 🎉 I hope neither you nor anyone else reading...

I still have difficulties wrapping my head around the question "What is the next actionable step?" here. Here's a Gist with standard checks that could be auto-fixable (including those fixed...

Thx for reprting! > Credo was returning all issues on the files changed on that branch, without checking if they were introduced on that branch or not. Could you describe...

> Credo complements the Formatter, and doesn't ever try to [...] contradict it @TheFirstAvenger In my mind, Credo's **default config** should conform with the formatter. I am not sure if...

This is a great start to discuss some of the necessary core concepts in more detail (and using an actual implementation, which is much appreciated)! Thanks for that! I will...