René Föhring
René Föhring
Hi, thx again for this. Unfortunately, I am closing it as I really never got why this check should be included as a standard check in Credo (the 1-sentence-explanation did...
Thanks for reporting this 😀 It should be fixed on `master`. You can try this by setting the Credo dep to ```elixir {:credo, github: "rrrene/credo"} ``` Please report back if...
I was not able to reproduce this with this module: ```elixir # order: [:moduledoc, :public_guard, :private_guard] defmodule Test do @moduledoc "" defguard is_bar(term) when term == :bar defguard is_baz(term) when...
Yes, undocumented guards, functions and macros are treated as "private". This was a choice by the original author of the check. We could add a parameter to disable this behaviour,...
I am in favor of this and have no problems with the slight change in handling heredocs. One thing that worries me: I tested this on a couple of small...
This looks good. I will merge it before the "x-mas release" 👍
Hi, thx for putting this together! I am in favor of merging it, except there is one case not covered: ```elixir defmodule CredoSampleModule do def some_function(id) do with {:ok, user}
Thx for reporting 👍 This sounds super strange. How many files are there? Meaning 68 out of how many are excluded?
@tomtaylor This may have been solved by #1232. You can try this by setting the Credo dep to ```elixir {:credo, github: "rrrene/credo"} ``` Please report back if your issue is...
Thx for reporting and your investigation! I have an idea how to improve this, let me tinker a bit 👍