René Föhring comments

Results 126 comments of


                                            René Föhring

Add an option to enable all checks

Can't you just generate a Credo config and enable all the disabled checks in it? `mix credo gen.config` as described in the docs: https://hexdocs.pm/credo/config_file.html

Credo.Check.Refactor.MatchInCondition fails when using pipe operator

Hi, this is sort of the intended behaviour (only allowing super simple assignments). But I can see that the latest patch breaks existing patterns and we should at least provide...

Credo.Check.Refactor.MatchInCondition fails when using pipe operator

Thanks for reporting this 😀 It should be fixed on `master` with a new config parameter called `allow_operators`. You can try this by setting the Credo dep to ```elixir {:credo,...

Credo.Check.Refactor.MatchInCondition fails when using pipe operator

@Gladear an oversight on my part. Sorry! 😬 Should work on `master`!

Fix default :excluded_paths regex in ModuleDependencies check to exclude first-level test files

Hi, thx for the PR. I think this now excludes all files in directories starting with `test`. Is this intended?

New readability check: OkWithoutErrorReturnValue

Hi, I think this is a great idea for a check. As you already hint at, the difficult part could be to trace these cases accurately via static analysis 👍