Richard R

Results 32 comments of Richard R

> `test_smail` fails Check the logs, it's a kstest failure, just re-run it

For reference: https://www.astropy.org/affiliated/#becoming-an-affiliated-package I feel we fall short on a couple of the criteria at the moment, specifically using astropy functions and adequate documentation. It's not clear what the timeline...

I noticed some examples and tests use custom defined cosmologies which detract from what's actually important in those cases. I would suggest using e.g. Planck15 to simplify and improve consistency...

If we use `default_cosmology` in our docstring examples, astropy could redefine it in the future and cause our tests to fail. I think we should define our own default cosmology...

Can you update the issue name, description and references to give more detail about the specific model you want to implement. Additionally, are we assuming that our existing halo mass...

We could probably just update `skypy/.github/ISSUE_TEMPLATE/new-model-proposal.md` and generalise it to be a "new feature" template which would cover both requests and proposals. We should probably also remove the language regarding...

My understanding of communication guidelines is that they would apply to **project members** communicating on **any topic**. I see this as separate from contributor guidelines which are there to help...

@itrharrison the hierarchy you proposed makes sense to me. Should we start a google doc for all members to develop this together, similar to how we worked on the code...

Comments from @bnord in #138: Communication guidelines will help us communicate fluidly and transparently. All participants knowing how we communicate is essential for trust pervading and persisting. - where we...

Perhaps you're right! I expect the document will be relatively short, simple and uncontroversial so drafting it on GitHub should be fine.