skypy
skypy copied to clipboard
ENH: example for galaxy demographics
Description
This PR adds an example to reproduce Figure 3 in de la Bella et al. 2021. Include sonification feature from Strauss. Merging this PR closes #514 . Inputs:
- Quenching model
- Weigel et al. 2016 data.
References
- de la Bella et al. 2021, Quenching and Galaxy Demographics, arXiv 2112.11110.
- Trayford J., 2021, james-trayford/strauss: v0.1.0 Pre-release, doi:10.5281/zenodo.5776280, https://doi.org/10.5281/ zenodo.5776280
Checklist
- [x] Follow the Contributor Guidelines
- [ ] Write unit tests
- [x] Write documentation strings
- [x] Assign someone from your working team to review this pull request
- [x] Assign someone from the infrastructure team to review this pull request
@rrjbca to play the audio files, I'll use this
import IPython IPython.display.Audio("skypy_active.wav")
Does that mean we need to make IPython a dependency in SkyPy only to run the example?
@rrjbca to play the audio files, I'll use this
import IPython IPython.display.Audio("skypy_active.wav")
Does that mean we need to make IPython a dependency in SkyPy only to run the example?
Sorry I only just saw this. Yes you should just add ipython
as an extra requirement for docs
in setup.cfg. I tested this locally and it worked fine.
test_smail
fails and the checks don't pass
test_smail
fails
Check the logs, it's a kstest failure, just re-run it
The docs are not picking up the latest changes but it renders well on my local machine. This needs #516 to be merged before this is ready.