Tom Noble

Results 16 comments of Tom Noble

After adding some prints, I've managed to narrow it down to [this](https://github.com/ros/ros_comm/blob/f5fa3a168760d62e9693f10dcb9adfffc6132d22/tools/rosgraph/src/rosgraph/masterapi.py#L134) line ``` rosrun test_package test.py Building Master object Building master uri Calling Master._reinit() Parsing http host and port...

Similar PR implemented for ROS1 here (adds ARROW_STRIP, more similar to LINE_STRIP in that the arrows are defined tip to tail): https://github.com/ros/common_msgs/pull/190 https://github.com/ros-visualization/rviz/pull/1786 The suggestion was to implement for ROS2...

@rhaschke Would you mind running the workflows?

@rhaschke Do you know who would still have permissions to run the workflows? Someone from the OSRF?

@rhaschke Thanks for running the checks. Would you be happy to merge this PR, or should I make the additional moveit changes first?

This was the dodgy line of code: ``` triangle.vertex_indices = {face->GetId(0), face->GetId(1), face->GetId(2)}; ``` Since `face->GetId(x)` is the index into `vtkPolyData` vertex list, which contains _all_ vertices. Since the selection...

Hey and thanks for the response. Search radius was set to 2 for the plane slice planner, which is working fine. Does the half edge generator also use one? (my...

Will check the mesh for duplicate vertices. Don't think there should be any. This is the updated code generating the mesh message: ``` shape_msgs::Mesh Mesh::toShapeMsgsMesh(std::vector faces) { std::map vertex_id_mapping; shape_msgs::Mesh...

As in the above issue, I've verified that the selection does not contain duplicate vertices or faces using the following code ``` shape_msgs::Mesh Mesh::toShapeMsgsMesh(std::vector faces) { std::map vertex_id_mapping; shape_msgs::Mesh mesh;...

Ah okay, I'll try with that variable set then thanks :+1: . Should those be fixed in noether then if the code isn't passing the clang check, or are they...