Eric Rozell

Results 105 comments of Eric Rozell

Also, autoFocus isn’t implemented on View, so you’d actually have to tab to the View to give it focus. Have you confirmed that the view actually has focus (e.g. either...

With #10671, in theory you could create this panel entirely in user land (without needing to make a change to RNW).

I think we get these "for free" no? Can this be closed?

https://github.com/facebook/react-native/pull/34944 will fix

It technically works today, but you must also set an `onPress` callback.

If this change lands, what's the rollout plan? In Messenger for example, we rely on the implementation detail that the React tag is set to the FrameworkElement::Tag property in various...

Labeled the PR as a breaking change at least, since strictly speaking it changes how apps should interface with RN.

> @rozele Is Msssenger setting the tag or just reading it? If you're just reading it you might not have to do anything. We just read the tag using FrameworkElement::TagProperty....

Hoping that conditionally running the border update logic only when there is actually a XAML CornerRadius property set is a good compromise. It's likely nearly as computationally expensive to detect...

Please note, there is some weirdness that occurs on Web where the borderRadius is only clamped when you use a `px` value for the border radius. Today, only `px` values...