Eric Rozell

Results 105 comments of Eric Rozell

We could potentially lump the AccessibilityInfoService and UIManagerService into a single "NativeModuleService" catch all for utilities needed for core native modules. Or put the AccessibilityInfoService APIs into the WindowService, since...

Switched to draft because I haven't tested the ReactRootView change yet. Will mark ready for review once I confirm it's working.

@asklar - confirmed working :), ready for merge.

@asklar and @jonthysell - I removed the `GetReactTag` API, this should be good to go now.

Please note, I've labeled this as, strictly speaking, this will change the contract of `Image.resolveAssetSource`, but assuming any 3rd party modules are doing appropriate URI validation, it's unlikely for anything...

IIRC, I think the XAML CornerRadius prop applies a custom clip path, which forces the effective equivalent of `overflow: hidden`. There are other issues with the `borderRadius` implementation as well...

The way we've worked around this in the past, e.g., for `autoFocus` properties on components like `TextInput`, is to wait for the XAML `FrameworkElement::Loaded` event. I wonder if we should...

> This needs some thought for how to fix reliably. I think the workaround described above could fix things pretty reliably - keeping a deferred focus state in UIManager in...

In case this helps in debugging, this scenario actually used to work fine with Composition in v0.63 - only started seeing issues in 0.68.

I think acceptsKeyboardFocus was deprecated / removed. Can you try focusable instead? https://github.com/microsoft/react-native-windows/commit/443f76a03724d0b456e4422499a768d4d02657d3