react-native-windows
react-native-windows copied to clipboard
microsoft
Add Text.onPressIn|Out
https://github.com/facebook/react-native/commit/1d924549cad75912191005c8f68dd73e15b07183 Adds 2 new events to <Text> - onPressin/onPressOut. We could add them too.
@rectified95 Can you confirm whether this is as simple as implementing these props in our view managers and where that code should go? As long as we don't need a native implementation for this it should be straightforward.
Hi @chrisglein and @rectified95, Can I work on this issue (if no one else is working on it)? And can you please point out the files where I need to make changes?
@sourabh112 I'm assigning this issue to you. The files that need to be changes would be the .windows.js forks of the Text files you can see in the original RN commit diff in the issue description. For reference, I previously added this to TextInput: https://github.com/microsoft/react-native-windows/pull/6754 One thing to note, though, is that I also added code firing JS events as a way of passing along the native XAML events there - I'm not sure if this is necessary, since there doesn't seem to be analogous code for iOS/Android: in short, you could check if the RN event routing system somehow invokes the in/out versions of Text.onPress, without us having to do that manually.
Thanks, @rectified95 for assigning this issue to me. I'm a bit confused at some points but I think I can figure it out on my own.
@rbrishabh Would you still be interested in taking this one over if the current assignee cannot complete the task?
@TatianaKapos Is this already complete? If not, will it make 0.69, or should it be moved to 0.70?
