react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard
verified publisher icon microsoft

Adds GetReactRootView method to XamlUIService

Open rozele opened this issue 3 years ago • 6 comments

Description

Type of Change

Erase all that don't apply.

  • New feature (non-breaking change which adds functionality)

What

We emulate this behavior in our app, it's probably better to expose the core functionality to walk the shadow node tree (rather than using VisualTreeHelpers).

Microsoft Reviewers: Open in CodeFlow

rozele avatar Aug 17 '22 01:08 rozele

Hello @asklar!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost avatar Aug 22 '22 16:08 ghost

Switched to draft because I haven't tested the ReactRootView change yet. Will mark ready for review once I confirm it's working.

rozele avatar Aug 22 '22 17:08 rozele

@asklar - confirmed working :), ready for merge.

rozele avatar Aug 22 '22 19:08 rozele

FWIW I had part of this in #9658 where I also try to move the actual storage to an attached property.

jonthysell avatar Aug 24 '22 21:08 jonthysell

@rozele Also FYI #10485

jonthysell avatar Aug 31 '22 23:08 jonthysell

@asklar and @jonthysell - I removed the GetReactTag API, this should be good to go now.

rozele avatar Sep 20 '22 16:09 rozele