Denis Roussel (ACSONE)

/ocabot migration contract_sale_invoicing

@dantiller2 Thanks for this. Don't hesitate to make a better readable PR's title like your last commit '[MIG] contract_sale_invoicing: Migration to 13.0'. It will help reviewers when having the PRs...

@kittiu Do you plan to finish this and add tests ?

@palkesh-aktivsoftware Thanks for this. Could you rename your last commit with something like '[15.0][MIG] contract_queue_job' ?

/ocabot migration contract_queue_job

Indeed, an explanation should be an improvement on conditions to have some actions possible (in interface) as it's in code but not really clear, even when debugging.

@adrienpeiffer Too much changes to cherry-pick ? :sweat_smile:

@AaronHForgeFlow

> However, regarding the name of the module and the field, I think that "vat_excluded" is more explicit (and consistent with other naming) than "no_tax" and "no_taxes". Thanks for your...

> > Thanks for your review. But no, you can have other taxes that are not vat. This should stay as is. > > I didn't understood. The field you...