account-financial-tools
account-financial-tools copied to clipboard
OCA
[10.0][FIX] Fix account_asset_management
Fix module account_asset_management.
How to reproduce: Create an asset with a residual amount at 0. Then "remove"/sell it with a price. Validate the wizard and check account move lines generated. You can notice that the selling amount doesn't appear anywhere.
Fix: During the "remove", generate move lines about the selling price.
Note for reviewers:
The diff seems very strange. I only remove the if residual_value: but git see that like 2 different parts (1 creation then a big delete). But only the indent change.
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
On my way to merge this fine PR! Prepared branch 10.0-ocabot-merge-pr-913-by-AaronHForgeFlow-bump-patch, awaiting test results.
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 10.0-ocabot-merge-pr-913-by-AaronHForgeFlow-bump-patch, awaiting test results.
@AaronHForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-913-by-AaronHForgeFlow-bump-patch.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
CI will not be green after rebase :(
Yes it's green :) You can merge it :) Thanks!
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 10.0-ocabot-merge-pr-913-by-dreispt-bump-patch, awaiting test results.
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-913-by-dreispt-bump-patch.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
This PR looks fantastic, let's merge it! Prepared branch 10.0-ocabot-merge-pr-913-by-dreispt-bump-minor, awaiting test results.
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-913-by-dreispt-bump-minor.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
What a great day to merge this nice PR. Let's do it! Prepared branch 10.0-ocabot-merge-pr-913-by-dreispt-bump-minor, awaiting test results.
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-913-by-dreispt-bump-minor.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@rafaelbn The rebase process failed, because command git push --force acsone tmp-pr-913:10.0-fix_account_asset_management failed with output:
remote: Permission to acsone/account-financial-tools.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/acsone/account-financial-tools/': The requested URL returned error: 403