Denis Roussel (ACSONE)

/ocabot migration product_contract

@mourad-ehm Could you check pre-commit and attend last comments?

> > @mourad-ehm can you fix pre-commit and test ? > > I did it but the error persist. I fixed it by this commande in local 'pre-commit run --show-diff-on-failure...

@mourad-ehm Do a git status locally. You'll see unadded setup folder. Tested with your branch: 

@mourad-ehm Could you squash not interesting commits ?

> > Thanks @rousseldenis > > Hi @mourad-ehm Thanks for rebase! Can you fix the test ? Which test ?

@etobella Could you answer @kittiu questions ?

@kittiu My question: Why depending on agreement_legal and not just on agreement as far as I can see, no code depends on that one?

Take also into account section lines.

> I was testing this fix, but still get the same error message. After archiving all contracts with "Date End" < now (Date of next invoice) I was able to...