14.0 mig product_contract

[mourad-ehm]

trafficstars

[hparfr]

@mourad-ehm please fix pre-commit and remove .format() as requested in v13 port PR.

[oa-eska]

https://github.com/OCA/contract/pull/590 this can be added as well.

[hparfr]

@mourad-ehm can you update this pr ?

[lukebranch]

@mourad-ehm ,

Please let me know if you would like any additional review or if you would be open to PR's against akretion/contract/tree/14.0-mig-product_contract. We have a need for this module in 14.0 and would like to offer an extra pair of hands if you open to this.

[lukebranch]

@mourad-ehm ,

Please let me know if you would like any additional review or if you would be open to PR's against akretion/contract/tree/14.0-mig-product_contract. We have a need for this module in 14.0 and would like to offer an extra pair of hands if you open to this.

@mourad-ehm ,

Not sure if you're still planning on working on this migration, but please let me know if you would like someone to take over and work on making the final changes required to take your product_contract migration over the finish line so it's ready to be merged.

We'd like to make use of this feature in 14.0 for a project but would like to make sure it's in stable 14.0 OCA/contract before making use of it.

[hparfr]

@lukebranch you can take over this migration. I don't think there will be any activity on this PR in the upcoming weeks.

[lukebranch]

@lukebranch you can take over this migration. I don't think there will be any activity on this PR in the upcoming weeks.

@hparfr,

Apologies for the late reply. Thanks for letting me know.

@mourad-ehm, please let me know if you end up wanting to pick this back up.

@hparfr, as this would be our first OCA contribution, I may need some time to get up to speed on OCA contribution requirements and processes. My apologies in advance for this.

In regards to picking up on the already substantial work that @mourad-ehm has already done, what would be the best way for me to get started? Should I fork the original repo at https://github.com/akretion/contract/tree/14.0-mig-product_contract and submit a new PR?

[designbybeck]

@mourad-ehm @lukebranch We are needing this in v14 as well. Anything we can do to help? We had some discussions about this on the Odoo OCA Matrix/Element chatroom (#oca-general:matrix.org). Should we just have those folks reply here (GitHub) for discussion on trying to get Product_Contracts working in v14?

@hparfr Why do you say there will be no work on it in the next few weeks?

Thank you.

[hparfr]

@hparfr Why do you say there will be no work on it in the next few weeks?

Mostly because of holidays.

In regards to picking up on the already substantial work that @mourad-ehm has already done, what would be the best way for me to get started? Should I fork the original repo at https://github.com/akretion/contract/tree/14.0-mig-product_contract and submit a new PR?

• This PR has been started a while ago, current v12 (and maybe v13) version have been improved.
• There is no new code in this PR (apart version in manifest )

So, I think it's better to re-start a migration and create your own PR.

Do not hesitate to read the migration guide : https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0

[centrixsystems]

@designbybeck @lukebranch @mourad-ehm @hparfr ,

We're also interested in migrating this module. We don't have the manpower on hand currently due to project workload, however we'd be interested to discuss if everyone wanted to pool resources to get this migrated to 14.0.

Is there an OCA-approved way to contribute resources towards a module migration, similar to a bug bounty?

[rousseldenis]

@mourad-ehm Could you please enhance your commit messages (something more like '[14.0][FIX] product_contract: Use with_company') ?

[rousseldenis]

@hparfr is this really on stale on your side ?

[centrixsystems]

@designbybeck @lukebranch @mourad-ehm @hparfr ,

We're also interested in migrating this module. We don't have the manpower on hand currently due to project workload, however we'd be interested to discuss if everyone wanted to pool resources to get this migrated to 14.0.

Is there an OCA-approved way to contribute resources towards a module migration, similar to a bug bounty?

Further to this comment a few months ago, we're interested in organising to pay someone else to migrate product_contract and build a solution for allowing e-commerce sales for subscription/payment by instalment (eg. select weekly, fortnightly, monthly, yearly variant on the product page in e-commerce to pay for the product in instalments, or perhaps purchase a yearly subscription).

I'm not sure if it's appropriate to write this here, so please advise if inappropriate and i'll delete the comment, however I feel this perhaps requires funding in order to push it forwards for version 14.0, which we are willing to discuss. Anyone interested in discussing please reach out to us on [email protected]. All code would be contributed back to the OCA and/or placed in a public repository.

[hparfr]

@mourad-ehm can you please integrate #590 and amend your commit as Denis suggested ?

[mourad-ehm]

Hi @rousseldenis, @hparfr I enhanced commit messages and I integrated commit of pr https://github.com/OCA/contract/pull/590

[mourad-ehm]

Thanks @rousseldenis for review

[scigghia]

Hello, Would someone merge this PR ?

[rousseldenis]

/ocabot migration product_contract

[rousseldenis]

@mourad-ehm Could you check pre-commit and attend last comments?

[elvise]

@mourad-ehm can you check pre-commit ?

[elvise]

@mourad-ehm can you fix pre-commit and test ?

[mourad-ehm]

@mourad-ehm can you fix pre-commit and test ?

I did it but the error persist. I fixed it by this commande in local 'pre-commit run --show-diff-on-failure --color=always --all-files' Do you have any suggestion ?

[rousseldenis]

@mourad-ehm can you fix pre-commit and test ?

I did it but the error persist. I fixed it by this commande in local 'pre-commit run --show-diff-on-failure --color=always --all-files' Do you have any suggestion ?

@mourad-ehm Could you try to rebase locally?

[mourad-ehm]

I rebased branch locally before fix pre-commit

[rousseldenis]

@mourad-ehm Do a git status locally. You'll see unadded setup folder.

Tested with your branch:

[mourad-ehm]

Thanks @rousseldenis

[elvise]

Thanks @rousseldenis

Hi @mourad-ehm Thanks for rebase! Can you fix the test ?

[rousseldenis]

@mourad-ehm Could you squash not interesting commits ?

[rousseldenis]

Thanks @rousseldenis

Hi @mourad-ehm Thanks for rebase! Can you fix the test ?

Which test ?

[elvise]

Thanks @rousseldenis

Hi @mourad-ehm Thanks for rebase! Can you fix the test ?

Which test ? @rousseldenis