Ricky O'Steen
Ricky O'Steen
Closing, this was possible but needed to be documented, which is done.
Thanks for writing up a proposal @pllim. Here are my thoughts: > My proposal for `__add__` and `__sub__`: > > * Throw error if `other` is not `Spectrum1D`. I think...
> > I think we should also allow other to be a Quantity of matching unit/shape > > Can you please clarify? It makes sense to allow scalar Quantity, but...
> > the unit compatibility checks you're proposing below aren't > > Well, I guess they can also be addressed in a different PR... Right, I'm not saying it shouldn't...
@eteq @nmearl @keflavich Any thoughts you want to throw in the pile here?
Ok, sounds like I'm outvoted on requiring `Spectrum1D` for non-scalars 👍
@PatrickOgle I'm trying to clean up some old issues, do you remember any resolution to this?
> Sorry, this dropped down my todo list, as a test of the changes, I've added the first pass of the SAMI loaders we're working on to the PR, which...
LGTM now that coverage is reporting properly.
Essentially, my use case is that I'm making sure one can initialize a `Spectrum1D` by inputting an `NDCube` object, and `Spectrum1D` demands that the spectral axis be last. So I...