Ross Barnowski

Results 471 comments of Ross Barnowski

It took me a second to understand this one, but I get it now: the issue is that `nx.from_numpy_array` reads from different parts of the adjacency matrix depending on whether...

I tested a few configurations locally and this is due to the recent release of [pytest 8.4](https://pypi.org/project/pytest/) which came out on June 2nd. FWIW there was a warning in place...

Man the GED code is complicated 🙃 I'm having trouble following this - I'm able to run the above example and reproduce the result, but I don't think I understand...

> Wondering if your idea only works with spring_layout? But spring_layout shows a different layout each time, shell_layout is stable. `spring_layout` is stochastic - if you want a reproducible result...

I'm not sure I understand the confusion - NetworkX is a Python library that deals in Python objects. Serializing objects to json is what the `json` package is for... I...

> Then the Cytoscape module should not be called JSON The name here reflects the fact that the cytoscape project uses JSON as a data-interchange format. > function's docstring should...

Another improvement would be to add tests to ensure the weighted `harmonic_diameter` is correct!

Since this didn't make the 3.4 release, I took the liberty of pushing up a signature change to maintain backward compatibility. My approval stands, though testing would be welcome!

> I think this is now ready. @rossbar can you take a look at the tests? Tests LGTM, thanks @dschult !

> Sorry to hear you will be out of action here for a long time. Best wishes on all your future projects! We'll be watching your career from afar. :)...