Address #775: Really make `char` in python a `str`

Open arjo129 opened this issue 2 years ago • 2 comments

This commit addresses #775 for rolling going forward.

Note: This commit breaks a lot of down stream tests. I will be pushing fixes one by one as I discover errors.

Jan 04 '24 01:01 arjo129

The fix here looks good to me! Let me know when they're ready and I'll review them all at once.

Jan 04 '24 20:01 sloretz

While I think this is the right thing to do, this is probably going to cause some heartache on downstream consumers.

To that end, I think we should be loud about the change. So I'll request that you please open up a PR to update http://docs.ros.org/en/rolling/Releases/Release-Jazzy-Jalisco.html with details of this change so that users who are switching to Jazzy are aware.

Jan 05 '24 19:01 clalancette

I don't think this change is worth it as downstream users will be left with a lot of "busy work"

Jun 07 '24 03:06 arjo129