ros2_documentation Revert "Revert "adding API change for spin_until

Revert "Revert "adding API change for spin_until_complete""

Open audrow opened this issue 2 years ago • 4 comments

trafficstars

⚠️ This is waiting on https://github.com/ros2/rclcpp/pull/1957 before being merged

Reverts ros2/ros2_documentation#3333, which originally reverted https://github.com/ros2/ros2_documentation/pull/3328.

Feb 13 '23 21:02 audrow

This shouldn't be a draft. Its ready to go with the feature merges

Feb 13 '23 22:02 SteveMacenski

@audrow please revert this. (edit, i mean merge this PR, sorry for the confusion.)

Feb 13 '23 22:02 fujitatomoya

@audrow please revert this. (edit, i mean merge this PR, sorry for the confusion.)

Now I'm confused -- so you want this merged now @fujitatomoya ?

Feb 14 '23 23:02 SteveMacenski

Oh sorry, i was the one who got confused.

Feb 14 '23 23:02 fujitatomoya

I've opened #4252 to replace this PR. Closing.

Apr 02 '24 22:04 christophebedard