ros2
fix: "Failed to parse type hash" message was overly spammy [ros2-50]
Having this message printed with too high of a verbosity level makes it too spammy in normal executions of the RMW, making it hard to work with the log files.
In 🧇 meeting we talked about taking this change and also adding a "log once". The log once call would say there was a type mismatch, and tell users to switch the logging mode to debug to see more info. Looking closer I now see that this is using an rmw_connext specific logging macro, and there's no log-once equivalent.
@clalancette what do you think about taking this change as-is?
The CI jobs have expired, I'm running them again:
- Linux:
- Windows:
Regarding @sloretz's comment, we can file a task to add the log-once feature but I prefer to keep it out of this PR to avoid feature creeping.
Linux build failed due to a lack of disk space in the CI machine. Re-running without changes:
@clalancette We are ready to merge this PR, but we have a couple of questions:
-
Are "merge commits" ok or should @trubio-rti rebase the branch?
-
If merge commits are ok, do they need the "Signed-off" tag in the message?
Based on your answers we might have to update (and re-run CI as a formality) before merging. Thank you for your help!
Pulls: ros2/rmw_connextdds#149 Gist: https://gist.githubusercontent.com/clalancette/1c2039635efe8ba930f73d1f3b5dd0cf/raw/c1bec87478370bddfd63538fb5d76d04488bdb5e/ros2.repos BUILD args: --packages-above-and-dependencies rmw_connextdds_common TEST args: --packages-above rmw_connextdds_common ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14453
- Linux
- Linux-aarch64
- Linux-rhel
- Windows
- Are "merge commits" ok or should @trubio-rti rebase the branch?
No, we never use Merge commits in the final commit. That said, using the "Squash and merge" button in GitHub should always do the right thing, which is what we use everywhere else.
That said, it looks like CI on this change wasn't completely run, so I ran it again.
