rclcpp icon indicating copy to clipboard operation
rclcpp copied to clipboard

feat: Implemented a timer manager that can handle any timer type

Open jmachowinski opened this issue 1 year ago • 2 comments

This is a draft commit as a basis for advancing the current timer manager implementation used by the events executor.

@alsora @fujitatomoya

jmachowinski avatar Jul 02 '24 17:07 jmachowinski

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/the-ros-2-c-executors/38296/13

ros-discourse avatar Jul 02 '24 22:07 ros-discourse

This implementation with a multimap rather than a priority queue is a lot simpler, but I would be curious to see the performance difference with respect to the current one.

IMO the current approach has benefits only when you have a lot of timers, but I doubt that executors will usually manage more than 10 timers each!

alsora avatar Jul 02 '24 23:07 alsora