rclcpp icon indicating copy to clipboard operation
rclcpp copied to clipboard

TimersManager doesn't follow ROS time

Open alsora opened this issue 1 year ago • 4 comments
trafficstars

Feature request

Feature description

Currently, the TimersManager class waits for timers to be ready using the following code

timers_cv_.wait_for(lock, time_to_sleep.value(), [this]() {return timers_updated_;});

This will always sleep using the system clock, even if the "time to sleep" was computed from a timer using the ROS clock

We should take into account the clock type when deciding how to sleep, and use an API that is aware of ROS clock

alsora avatar Apr 03 '24 14:04 alsora

duplication of https://github.com/ros2/rclcpp/issues/2457. lets keep this alive as tracking issue, and i will close https://github.com/ros2/rclcpp/issues/2457. CC: @alsora

fujitatomoya avatar Apr 03 '24 16:04 fujitatomoya

Ops, my bad. I started looking into this problem and created a ticket without noticing we already had one.

alsora avatar Apr 03 '24 16:04 alsora

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/the-ros-2-c-executors/38296/4

ros-discourse avatar Jun 24 '24 00:06 ros-discourse

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/the-ros-2-c-executors/38296/13

ros-discourse avatar Jul 02 '24 22:07 ros-discourse