rclcpp icon indicating copy to clipboard operation
rclcpp copied to clipboard

deprecated callback_group from publisher option

Open iuhilnehc-ynos opened this issue 3 years ago • 5 comments

Follow-up PR for https://github.com/ros2/rclcpp/pull/1833.

Signed-off-by: Chen Lihui [email protected]

iuhilnehc-ynos avatar Jan 04 '22 02:01 iuhilnehc-ynos

CI with --packages-above-and-dependencies rclcpp rclcpp_lifecycle

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

iuhilnehc-ynos avatar Jan 04 '22 03:01 iuhilnehc-ynos

Rerun CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

iuhilnehc-ynos avatar Jan 04 '22 09:01 iuhilnehc-ynos

@iuhilnehc-ynos thanks for the follow-up, i will also take a look at this.

fujitatomoya avatar Jan 04 '22 17:01 fujitatomoya

Should we wait for #1833 to be merged first?

alsora avatar Jan 18 '22 15:01 alsora

@alsora i think so, since this is follow-up.

fujitatomoya avatar Jan 18 '22 16:01 fujitatomoya

@iuhilnehc-ynos this should be closed aligned with https://github.com/ros2/rclcpp/pull/1833? if that so, please go ahead to close this.

fujitatomoya avatar Dec 07 '22 18:12 fujitatomoya