message_filters icon indicating copy to clipboard operation
message_filters copied to clipboard

Use RCL_ROS_TIME for message_traits::TimeStamp for Foxy

Open pschalkwijk opened this issue 2 years ago • 1 comments

Also taken from the rolling branch

  • when creating TimeStamp, make sure RCL_ROS_TIME is being used, and not RCL_SYSTEM_TIME.

Signed-off-by: Kenji Brameld [email protected]

  • Update include/message_filters/message_traits.h

Co-authored-by: Sivert Havso [email protected]

  • add test to ensure message_filters::message_traits::TimeStamp<Msg>::value returns a time with RCL_ROS_TIME time source

Signed-off-by: Kenji Brameld [email protected]

Co-authored-by: Sivert Havso [email protected]

pschalkwijk avatar Jul 19 '22 13:07 pschalkwijk

This appears to be changing the behaviour of an API. Can you please explain what you are expecting from this change and why it is appropriate to backport it to Foxy?

gbiggs avatar Jul 19 '22 23:07 gbiggs

FYI This is a backport of https://github.com/ros2/message_filters/pull/72

ralwing avatar Dec 07 '22 09:12 ralwing

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

quarkytale avatar May 15 '23 18:05 quarkytale