message_filters icon indicating copy to clipboard operation
message_filters copied to clipboard

Get topic name from base class to propagate remaps

Open guilyx opened this issue 3 years ago • 2 comments

When remapping a topic foo to bar, it appears that Subscriber::getTopic returns the name of the topic as initialized when instantiating the subscriber foo. In the base class, get topic returns the remapped topic bar, which is in my opinion the correct behavior to go to.

If I were to retrieve the topic I'm subscribing to, I expect to retrieve the remapped name (aka the true name) rather than something that is not used.

guilyx avatar Dec 06 '21 15:12 guilyx

@guilyx Could you please add a test that verifies the new behaviour?

gbiggs avatar Feb 19 '22 06:02 gbiggs

@gbiggs Sure, will take a few days

guilyx avatar Feb 25 '22 11:02 guilyx