choco-packages icon indicating copy to clipboard operation
choco-packages copied to clipboard

Published 20 hours ago • verified publisher icon ros2

Use Upstream Eigen3Config.cmake

Open sloretz opened this issue 2 years ago • 0 comments

The chocolatey package for Eigen currently ships a custom EigenConfig.cmake, but it only sets old-style CMake variables. The upstream EigenConfig.cmake sets CMake targets. I think the upstream one should be used here.

This repo's

https://github.com/ros2/choco-packages/blob/45edd8472510a3fb22e3aa94f3cbc29ff4cc4109/package/eigen/share/cmake/Eigen3Config.cmake#L1-L6

Upstream's https://gitlab.com/libeigen/eigen/-/blob/master/cmake/Eigen3Config.cmake.in#L7

sloretz avatar Apr 01 '22 01:04 sloretz