rosdistro icon indicating copy to clipboard operation
rosdistro copied to clipboard

Adding aruco_ros2 to index for distro

Open david-wb opened this issue 1 year ago • 1 comments

Note: It's my first time trying to release a ros2 package. Apologies in advance for any mistakes on my part. I am following these instructions.

Please Add This Package to be indexed in the rosdistro.

humble jazzy rolling

The source is here:

https://github.com/namo-robotics/aruco_ros2

Checks

  • [x] All packages have a declared license in the package.xml
  • [x] This repository has a LICENSE file
  • [x] This package is expected to build on the submitted rosdistro

david-wb avatar Jan 30 '25 12:01 david-wb

@david-wb can you point out differences (if any) between aruco_ros, aruco_opencv and the one proposed here?

marcoag avatar Feb 20 '25 11:02 marcoag

@marcoag aruco_ros is out-of-date and unmaintained, and was not working with the gazebo camera sensor, so I created this new version which has the following properties:

  • Clear and simple API with full examples in the README
  • Supports selecting the arcuco dictionary to use
  • Works with gazebo camera sensor

I'm not familiar with aruco_opencv but it seems to have similar limitations as aruco_ros, at least for my use case.

david-wb avatar Feb 20 '25 12:02 david-wb

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

github-actions[bot] avatar Mar 19 '25 11:03 github-actions[bot]

New package checklist:

  • [x] At least one of the following must be present
    • [x] Top level license file: https://github.com/namo-robotics/aruco_markers/blob/humble/LICENSE
    • [x] Per package license files:
  • [x] License is OSI-approved: MIT
  • [x] License correctly listed in package.xmls
  • [x] Public source repo: https://github.com/namo-robotics/aruco_markers
  • [x] Source repository contains ROS packages
  • [x] Each package meets REP-144 naming conventions

@marcoag are you satisfied with the explanation above? https://github.com/ros/rosdistro/pull/44321#issuecomment-2671300411

christophebedard avatar Mar 26 '25 18:03 christophebedard

@christophebedard I haved renamed the project from aruco_ros2 to aruco_markers. Does this help complete the new package checklist above?

david-wb avatar Mar 31 '25 12:03 david-wb

Yeah, I think that's fine.

Could you re-order your entries alphabetically? See the failing CI job.

christophebedard avatar Mar 31 '25 15:03 christophebedard