rosdistro icon indicating copy to clipboard operation
rosdistro copied to clipboard

Add rosbag2_to_video to rolling index

Open bjsowa opened this issue 1 year ago • 2 comments

Please Add This Package to be indexed in the rosdistro.

rosbag2_to_video

The source is here:

https://github.com/fictionlab/rosbag2_to_video

Checks

  • [x] All packages have a declared license in the package.xml
  • [x] This repository has a LICENSE file
  • [x] This package is expected to build on the submitted rosdistro

bjsowa avatar Aug 22 '24 21:08 bjsowa

New package review checklist

  • [x] At least one of the following must be present
    • [x] Top level license file:
    • [ ] Per package license files:
  • [x] License is OSI-approved: https://opensource.org/license/apache-2-0
  • [x] License correctly listed in package.xmls
  • [x] Public source repo: https://github.com/fictionlab/rosbag2_to_video, but this is a fork of the upstream
  • [x] Source repository contains ROS packages
  • [x] Each package meets REP-144 naming conventions

I have two issues that prevent me from approving this:

  1. The version number is 0.0.0, which, while technically allowed, isn't great. I'd like to see that bumped to some number that isn't 0.
  2. We've only given the real upstream 2 weeks to respond to a request for release. I'll suggest we wait a bit longer before deciding to make the fork official.

clalancette avatar Aug 26 '24 15:08 clalancette

  1. The version number is 0.0.0, which, while technically allowed, isn't great. I'd like to see that bumped to some number that isn't 0.

Fixed

  1. We've only given the real upstream 2 weeks to respond to a request for release. I'll suggest we wait a bit longer before deciding to make the fork official.

What would be the appropriate time to consider the fork official?

bjsowa avatar Aug 29 '24 11:08 bjsowa

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

github-actions[bot] avatar Sep 13 '24 11:09 github-actions[bot]

bump

bjsowa avatar Sep 13 '24 11:09 bjsowa

@clalancette Could you reconsider it now?

bjsowa avatar Sep 27 '24 14:09 bjsowa

@clalancette friendly ping

bjsowa avatar Oct 09 '24 15:10 bjsowa

fyi @ivanpauno

methylDragon avatar Oct 17 '24 23:10 methylDragon

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

github-actions[bot] avatar Nov 01 '24 11:11 github-actions[bot]