Changes due to gurumdds package integration

[YoungJin-gurum]

Package name:

rmw_gurumdds

ROS Distro.

foxy

The source is here:

https://github.com/ros2/rmw_gurumdds.git

[nuclearsandwich]

@YoungJin-gurum changes like this are usually handled via automatic pull request generation when creating new releases with bloom-release. Were you able to run bloom for these changes and if so, are there automated PRs that were opened to take care of these changes or was there an issue when running bloom?

[YoungJin-gurum]

@nuclearsandwich I know that pull requests are usually handled by generation automatically, but there was an issue when running bloom. When I tried bloom-release, I got the following error: Failed to open pull request: AssertionError - Duplicate package name 'gurumdds_cmake_module' exists in repository 'rosidl_typesupport_gurumdds' as well as in repository 'rmw_gurumdds' So I manually edited it and opened a pull request. Please let me know if there is any other way I should take in this case. Thanks.

[methylDragon]

@nuclearsandwich I know that pull requests are usually handled by generation automatically, but there was an issue when running bloom. When I tried bloom-release, I got the following error: Failed to open pull request: AssertionError - Duplicate package name 'gurumdds_cmake_module' exists in repository 'rosidl_typesupport_gurumdds' as well as in repository 'rmw_gurumdds' So I manually edited it and opened a pull request. Please let me know if there is any other way I should take in this case. Thanks.

Erm, I think that's because there are packages called gurumdds_cmake_module in both of those repos.

https://github.com/ros2/rmw_gurumdds/tree/master/gurumdds_cmake_module https://github.com/ros2/rosidl_typesupport_gurumdds/tree/master/gurumdds_cmake_module

One of them will have to go, otherwise a user installing both will have conflicts. Or split it off into its own repo?

Edit: Okay, I see that that's probably the reason you're deleting the rosidl_typesupport_gurumdds package.. I'll defer to @nuclearsandwich for how to handle deleting a package entry from rosdistro

[nuclearsandwich]

When I tried bloom-release, I got the following error: Failed to open pull request: AssertionError - Duplicate package name 'gurumdds_cmake_module' exists in repository 'rosidl_typesupport_gurumdds' as well as in repository 'rmw_gurumdds' So I manually edited it and opened a pull request. Please let me know if there is any other way I should take in this case. Thanks.

Thanks for the explanation. Bloom is designed to only consider a single repository at a time so when packages between repositories conflict we do need some manual intervention.

I'll suggest the following:

1. Update this PR so that it is just removing rosidl_typesupport_gurumdds
2. We'll merge it directly since none of the affected distributions are in a sync hold currently.
3. Then you can make the bloom release for rmw_gurumdds normally since the conflict between the two will have been removed.
4. We'll also review and merge that directly to reduce the time between the two changes.

How does that sound?

[nuclearsandwich]

And just now there's a Foxy sync hold starting: https://discourse.ros.org/t/preparing-for-foxy-sync-2022-11-09/28209 with that in mind let's split the changes to Foxy in a separate set of PRs to do later.

[YoungJin-gurum]

@nuclearsandwich

1. Update this PR so that it is just removing rosidl_typesupport_gurumdds

How do I update this PR? Let me know what should I change.

[nuclearsandwich]

How do I update this PR? Let me know what should I change.

I've added some comments to each section. Let me know if I can provide further explanation.

[YoungJin-gurum]

@nuclearsandwich I revert the package version and list, just removing rosidl_typesupport_gurumdds. Please let me know if there are any additional corrections I need to make.

[ivanpauno]

Holding for Humble sync

[ivanpauno]

Holding for Foxy sync

[nuclearsandwich]

@YoungJin-gurum I'm also starting a Rolling sync this week as well.(link). If Rolling merges first, I'll refactor this PR so that we can update Rolling immediately after the sync.

Thanks for iterating on this so far, we'll take care of the changes as each release completes.

[YoungJin-gurum]

@nuclearsandwich Thanks. I'll wait for sync.

[nuclearsandwich]

@YoungJin-gurum you should now be able to bloom the new versions of rmw_gurumdds normally. Thanks again for your patience during this process.