robot_state_publisher
robot_state_publisher copied to clipboard
ros
added repitition to robot_description reading
I think that the best implementation of this feature would be to add description_read_repetitions and description_read_delay as ROS parameters with default values if the parameters are not set on the server.
@jacquelinekay Makes sense. I changed it accordingly. I am not sure about default values though.
I would consider making the default value for default_descriptions_read_repetitions 0. That way users can opt into the new behavior.
@ros/ros_team and @ros/robot_model, do you have any feedback on this new workaround for nondeterministic startup behavior?
Hi @jacquelinekay just checking if this PR can be merged or there is some fundamental disagreement on the content.
If it's going to be merged we can resolve the conflicts.
This has been rebased and the checks are passing. Do you think it can be merged?
Hi @toliver, thanks for the contribution. If I understand correctly this enables robot_state_publisher to wait for the parameter "robot_description" to be set for a fixed amount of time.
Would you mind adding a test to make sure it does not wait by default, and a test to make sure it can wait when the two parameters are set?
Sorry to nose in, are there plans to move ahead with this pull request? It would be useful for my application as well. I can help with the requested changes if need be.
I'm wondering if there is a nicer way to do this ,rather than just polling for a set amount of time. That is, it seems to me like it might be better for robot_state_publisher to have a configurable topic that would get published to once the robot description is available. That way, it would just wait around until that event happened, rather than polling the parameter server. Thoughts about an approach like that?
