navigation icon indicating copy to clipboard operation
navigation copied to clipboard

default_tolerance parameter in global_planner does not working

Open jihoonl opened this issue 10 years ago • 7 comments

It seems like default_tolerance parameter is not used in global planner package.

makePlan function in global planner receives tolerance but not use anywhere.

jihoonl avatar Oct 21 '14 02:10 jihoonl

Any update on this? It seems this is not resolved yet even after 2 years.

AravindaDP avatar Dec 07 '16 13:12 AravindaDP

On the other hand this kind of behavior is available in MoveBase::planService service call method. https://github.com/ros-planning/navigation/blob/kinetic-devel/move_base/src/move_base.cpp#L334

May be I can implement a similar behavior here and make a pull request?

@DLu what do you think?

AravindaDP avatar Dec 08 '16 11:12 AravindaDP

This issue is still present as of today, it would make my life so much easier. Any input on this?

juanluishortelano avatar Apr 26 '17 11:04 juanluishortelano

Adding help wanted, since I'm not too familiar with that planner, and it looks like DLu is busy. PRs welcome.

mikeferguson avatar Mar 28 '18 22:03 mikeferguson

I added my own version of default_tolerance use, it solves my problem when a goal is obstructed. Does it help you in your case? https://github.com/jungladicitta/navigation/commit/b20495241ae81dd1dbeef4f585fb270cf4c8bda2

jungladicitta avatar Jun 30 '20 12:06 jungladicitta

@jungladicitta I am interested in this feature too, could you PR your version ?

doisyg avatar Oct 16 '20 10:10 doisyg

@doisyg just did it #1040

jungladicitta avatar Oct 16 '20 11:10 jungladicitta