moveit2 icon indicating copy to clipboard operation
moveit2 copied to clipboard

Fix overriding binary install

Open tylerjw opened this issue 2 years ago • 5 comments

Overriding is when you build a package from a source that is also installed as a binary. Currently, this does not work in MoveIt because of the way header files are found. The problem is that the binary header is found before the source header when building and if the source one is newer and has changes the compile will break in surprising ways.

#1901 is a good example of what needs to be done everywhere in moveit.

Here are the colcon docs on overriding: https://colcon.readthedocs.io/en/released/user/overriding-packages.html#how-to-make-it-easier-for-your-users-to-override

Tasks:

  • [ ] Search for cmake files that are missing this package directory
  • [ ] Make PR fixing the issue

tylerjw avatar Feb 03 '23 20:02 tylerjw

@tylerjw I think we can close this issue as it is already merged.

bailaC avatar May 30 '23 13:05 bailaC

I do not believe the linked to PR fixed this for the whole codebase.

tylerjw avatar May 30 '23 14:05 tylerjw

Hi @tylerjw I really would like to work on this. can I?

mariobo8 avatar Dec 11 '23 00:12 mariobo8

@mariobo8 Yes, go for it.

sjahr avatar Dec 11 '23 07:12 sjahr

is this issue still open?

advait-zx avatar Sep 21 '24 19:09 advait-zx

Duplicate of https://github.com/moveit/moveit2/issues/3134 which has more recent documentation to work from

mikeferguson avatar Dec 17 '24 16:12 mikeferguson