perception_pcl icon indicating copy to clipboard operation
perception_pcl copied to clipboard

1.7.4 does not include the fix the missing BOOST FOREACH macro

Open a1aw opened this issue 2 years ago • 3 comments
trafficstars

Hi, I was compiling ros-noetic-desktop-full in my arch linux installation. And found that the latest 1.7.4 release does not include the fix https://github.com/ros-perception/perception_pcl/commit/eb8f009ca519fc6b5651ba3a125fe5ae04f67bb8 for the missing BOOST FOREACH macro, causing me unable to compile this package.

The current boost version installed is 1.81.0

/home/anth/.cache/paru/clone/ros-noetic-pcl-ros/src/perception_pcl-1.7.4/pcl_ros/include/pcl_ros/point_cloud.h:231:15: error: there are no arguments to ‘BOOST_FOREACH’ that depend on a template parameter, so a declaration of ‘BOOST_FOREACH’ must be available [-fpermissive]
  231 |               BOOST_FOREACH(const pcl::detail::FieldMapping& fm, mapping) {
      |               ^~~~~~~~~~~~~

https://github.com/ros-perception/perception_pcl/blob/1.7.4/pcl_ros/include/pcl_ros/point_cloud.h

a1aw avatar Feb 15 '23 09:02 a1aw

A release for Noetic was last done in Feb '22 (that commit is from July). Assuming PCL shouldn't be changing mid-distribution and you're compiling with the supported PCL version for your distribution per REP 2000, you should be compiling fine. If you're using a newer version, then yes, there can be issues with compatibility - since arbitrary versions of PCL are not officially supported (this is why we have REP 2000).

We can run a release though in the coming weeks. I generally overlook ROS 1 at this point since no new development is happening there across the ecosystem.

SteveMacenski avatar Feb 15 '23 19:02 SteveMacenski

@SteveMacenski Are there still plans for a release?

mvieth avatar May 11 '23 08:05 mvieth

It looks like @paulbovbel made a release for 1.7.5 about 4 months ago. Should/can that be released into bloom Paul?

@mvieth to be honest, I don't really keep track of ROS 1 anymore. Nav2 has blown so far past ROS Navigation I couldn't even imagine going back :-)

SteveMacenski avatar May 18 '23 01:05 SteveMacenski