image_transport_plugins icon indicating copy to clipboard operation
image_transport_plugins copied to clipboard

Published 20 hours ago • verified publisher icon ros-perception

[ADD] flag for jpeg compression of bayer format

Open wodtko opened this issue 2 years ago • 7 comments

This PR adds a flag that allows for jpeg compression of Bayer encoded images. Although I fully understand why one does not want a lossy compression of Bayer encoded image, it worked pretty well for us when testing it with multiple camera images.

We really want to use compressed Bayer images to get recordings smaller, e.g. we record 10Hz image_streams of 8 cameras with 3MP each. With this PR there is no need for "inflating" the data to a color image prior to compression.

wodtko avatar May 13 '22 16:05 wodtko

is there any reason for not introducing this this parameter? We are using this functionality every time, but we need to keep it forked...

wodtko avatar Feb 28 '23 08:02 wodtko

conflicts are fairly simple and I will solve them, if the general idea is welcomed.

wodtko avatar Feb 28 '23 08:02 wodtko

I would also be interested in this, any maintainer willing to review this? @wodtko , you may be interested in my comment on #68

andrei-ng avatar Aug 18 '23 13:08 andrei-ng

Thanks for bringing it up again @andrei-ng :D I was only using ROS2 in this specific context, so I'm not sure about the exact issue in ros noetic.

However, different to the result in the issue mentioned, the bayer image is currently converted to a mono image prior to compression. Thus, there is no way of retrieving a color image afterwards... This PR adds a separate section for handling bayer formats to omit the mono color conversion.

wodtko avatar Aug 31 '23 09:08 wodtko

Thanks for bringing it up again @andrei-ng :D I was only using ROS2 in this specific context, so I'm not sure about the exact issue in ros noetic.

However, different to the result in the issue mentioned, the bayer image is currently converted to a mono image prior to compression. Thus, there is no way of retrieving a color image afterwards... This PR adds a separate section for handling bayer formats to omit the mono color conversion.

@wodtko , thanks for the clarification. I haven't used ROS2 in this context. I hope that by the time I use it, your PR will be merged :) .

andrei-ng avatar Sep 04 '23 08:09 andrei-ng

Well, if anyone would review my changes, I would be happy to resolve any CI issues. (mainly rebasing this PR)

wodtko avatar Sep 04 '23 16:09 wodtko