image_common icon indicating copy to clipboard operation
image_common copied to clipboard

Add support for missing CameraInfo.msg fields

Open UniBwTAS opened this issue 4 years ago • 5 comments

Missing (and added) fields are: binning_x binning_y roi.x_offset roi.y_offset roi.height roi.width roi.do_rectify

We (and I think also other developers) need to be able to set a certain ROI in our camera driver. So we added support for these fields in the YAML parser. It is fully backwards compatible, with old config files.

UniBwTAS avatar Oct 13 '20 11:10 UniBwTAS

@mjcarroll Do you have any thoughts on this pull request?

UniBwTAS avatar Nov 03 '20 09:11 UniBwTAS

@ahcorde Can you review this pull request?

UniBwTAS avatar Aug 23 '21 12:08 UniBwTAS

The additions look OK to me, but I'm going to get a second opinion just in case.

Have you got a test that has the existing fields but not your new ones, to verify that existing configuration files will work without errors?

gbiggs avatar May 05 '22 02:05 gbiggs

I didn't do a detailed review, but it does look like this is backwards compatible. So I'd say this is generally OK.

clalancette avatar May 05 '22 14:05 clalancette

I didn't do a detailed review, but it does look like this is backwards compatible. So I'd say this is generally OK.

clalancette avatar May 05 '22 14:05 clalancette