ros-perception
scan_offset parameter for Ros2
Similar to this PR: https://github.com/ros-perception/depthimage_to_laserscan/pull/28 I added a scan_offset parameter for the ROS2 version.
@chadrockey I just wanted to aks if you could make a statement on roughly when someone could look at this PR?
@YBachmann This is failing all of the tests because it doesn't conform to our style. Please fix the tests to pass, then we can take a look at reviewing it.
@YBachmann This is failing all of the tests because it doesn't conform to our style. Please fix the tests to pass, then we can take a look at reviewing it.
@clalancette The tests are now passing, sorry for not having them fixed earlier.
@clalancette do you have any open points you want to discuss or have changed?
PS: I also opened another PR https://github.com/ros-perception/depthimage_to_laserscan/pull/82 , I would really appreciate if you could take a look at it as well :)
Hello @clalancette , as some time went by, I just wanted to ping this to check if you want me to make some more changes or if this could be merged soon.
Hello @chadrockey ,
could you please take a look at this PR? We had a discussion in PR https://github.com/ros-perception/depthimage_to_laserscan/pull/82 on whether it makes sense to add more functionality/complexity to this package, but I think this PR adds a nice and simple feature without much complexity.
PS: This PR also clarifies the description of scan_height in the README.md, which would make PR https://github.com/ros-perception/depthimage_to_laserscan/pull/79 irrelevant.
+1, this is a feature I needed, unknowingly (re)implemented almost identically, and which I intended to submit as well.
