motoman
motoman copied to clipboard
ros-industrial
Add CMake support for MotoPlus builder
Well done Julien. This file is working great in our lab, I support the pull request.
Thanks for the PR.
I'm wondering though: this seems to duplicate quite a bit of information which is already part of the various .mps files and the existing visual studio solution file.
I'm not against merging this, but duplication would be something to avoid.
Could you not have reused the .mps files?
Thanks for the feed back !
Originally, I wrote this file to use another IDE than MotoPlus IDE. I talked about that with Yaskawa France and it was possible with MpBuilder, and possibly without having Visual Studio IDE but using Visual Studio file project. So the purpose of my original commit.
But for this project, it's more interesting to use each mps file and existing vxproj file, so the updated commit.
So to get it clear: this adds a CMake macro which generates command lines to instruct mpbuilder.exe (from the MotoPlus SDK) to build MotoROS. Correct?
Originally, I wrote this file to use another IDE than MotoPlus IDE. I talked about that with Yaskawa France and it was possible with MpBuilder, and possibly without having Visual Studio IDE but using Visual Studio file project. So the purpose of my original commit.
But for this project, it's more interesting to use each mps file and existing vxproj file, so the updated commit.
thanks for this comment, I know understand better what you're trying to do.
I believe it would be fine to have some infrastructure to build MotoROS with mpbuilder.exe but without Visual Studio. If that was your original intent, we could merge that here, but we'd probably have to a) make that very clear and b) not name it CMakeLists.txt, but give it some sort of suffix to clearly indicate the use-case.
So to get it clear: this adds a CMake macro which generates command lines to instruct mpbuilder.exe (from the MotoPlus SDK) to build MotoROS. Correct?
Exactly! Thanks for your answer!
I believe it would be fine to have some infrastructure to build MotoROS with mpbuilder.exe but without Visual Studio. If that was your original intent, we could merge that here, but we'd probably have to a) make that very clear and b) not name it CMakeLists.txt, but give it some sort of suffix to clearly indicate the use-case.
I agree with your comment, I will see to re-think the content on a clear way and propose an appropriated name for it. Thank you very much!
I'm not sure I follow @Julien-Livet and @Gaspard-Bourgeois: why did you close the PR?
Hey @gavanderhoorn . I think @Gaspard-Bourgeois didn't know that he was closing the PR. I think he is new to open source community :). We will reach him.
Sorry for that !
