cros icon indicating copy to clipboard operation
cros copied to clipboard

Opening msg definition files failes on Windows

Open eibach opened this issue 4 years ago • 2 comments

When I try to start the sample programs(Windows, VS2017) I get errors concerning the format of the message definition files in the db folder.

eibach avatar Apr 30 '20 12:04 eibach

Ok, got it. It's all about using "rb" in fopen() which leads to windows line endings not transformed, which results in strtok() doing the wrong thing. Should I supply a Pull request?

eibach avatar Apr 30 '20 18:04 eibach

If you've found an issue it would be great if you could contribute a PR which fixes it.

Do take into account this code is supposed to be platform agnostic (or at the very least work on Linux and Windows), so it may be necessary to "intelligently" add or remove the b there (read: conditionally compile probably).

gavanderhoorn avatar May 05 '20 15:05 gavanderhoorn