Rootul P

Results 489 comments of Rootul P

Where? I don't see it [here](https://github.com/celestiaorg/cosmos-sdk/blob/ebcbe9dbe555cd5e7fd2a5694007fc90bcb14b0b/types/context.go#L84-L85).

> I've researched this thoroughly. The upstream CometBFT behavior (confirmed by checking their latest code) returns empty success responses like {"result":{"header":null}} when blocks are missing, which violates the JSON-RPC spec....

We agreed to resolve the issue https://github.com/celestiaorg/celestia-core/issues/2043 but I'm not 100% confident we need this PR. IMO we need someone to investigate why we need to diverge from upstream CometBFT...

How was this PR tested? Did you run the e2e test before + after this change to confirm that the template works as expected? Can you please document testing in...

Correct. Ref: https://github.com/celestiaorg/go-square/blob/6be96324999598f641bdb20ef0fb7043cece4d95/builder.go#L181-L183

> All on-chain governance modifiable parameters should become versioned parameters Clarifying question: do you mean all params or just the params related to the gas scheduler? I'm a fan of...

The two params that are being considered: - auth.TxSizeCostPerByte - blob.GasPerBlobByte

For posterity: - CIP: https://github.com/celestiaorg/CIPs/blob/main/cips/cip-24.md - Implementation: https://github.com/celestiaorg/celestia-app/pull/3735

> Does the user decide which namespace version is used? Yes the user decides which namespace version they want to use when they submit a MsgPayForBlob. See [NewMsgPayForBlobs](https://github.com/rootulp/celestia-app/blob/511c7d0233b614f82cc6c4c0f8d03f6586d3acee/x/blob/types/payforblob.go#L48) which has...