Rootul P

Results 489 comments of Rootul P

> I see, would it be possible for core to expose the current mempool-aware remaining blob space then? Since one node's mempool can differ from another node's mempool, I think...

> Mempool accounts for padding shares The ante handler could be made more sophisticated and construct a data square with only one PFB tx in it. This could "simulate" the...

> You say it leaked implementation detail, but it's unclear what exactly was leaking there to warrant a revert without a follow-up fix. From https://github.com/celestiaorg/rsmt2d/pull/295 I said it leaks this...

liveness-test failure is not unique to this PR: https://github.com/celestiaorg/cosmos-sdk/issues/441 cc: @adlerjohn

Blocked on v4.x hitting mainnet

I don't understand how the original solution was self-describing if celestia-app needs a registry of tree names to tree options. I'm in favor of a solution that doesn't need the...

Going to close this in favor of reverting the limit entirely.

> Well, self-describing does not imply a lack of registry. The JSON representation is not self-describing if it depends on a registry from tree name to tree options in order...

> An idempotent Register function would resolve this issue. Agreed.

Feedback from Oliver: > In general it would be nice for this example to explain how to set up a funded wallet and anything needed to run a local test...