celestia-core icon indicating copy to clipboard operation
celestia-core copied to clipboard

Delete unmaintained branches

Open rootulp opened this issue 2 years ago • 2 comments

It's difficult to see which branches are actively maintained on this repo. If we delete unmaintained branches in Github UI, then we can enable contributors to more easily see the branches that are relevant, (likely a handful including v0.34.x-celestia and v0.35.x-celestia). I don't think this is risky b/c it's possible to restore a deleted branch from Github UI.

Screen Shot 2022-08-12 at 3 17 50 PM

rootulp avatar Aug 12 '22 19:08 rootulp

@evan-forbes any objections to me doing this for branches that haven't been updated in the past month?

rootulp avatar Aug 12 '22 19:08 rootulp

To reduce the frequency of this chore, a repo admin should enable this setting on https://github.com/celestiaorg/celestia-core/settings:

Screen Shot 2022-08-14 at 11 59 05 AM

rootulp avatar Aug 14 '22 16:08 rootulp

To reduce the frequency of this chore, a repo admin should enable this setting on https://github.com/celestiaorg/celestia-core/settings:

this is already set :grimacing: I think I just need to stop polluting origin :sweat_smile:

I'll move all of my old branches over to a fork later today

evan-forbes avatar Aug 15 '22 05:08 evan-forbes

Sounds good, please assign back to me after you move branches and I can delete the remainder of stale branches

rootulp avatar Aug 15 '22 13:08 rootulp

We also want to deprecate master to avoid links to outdated content. Example: https://github.com/celestiaorg/docs/blob/069623334073d5b2c4b626f732f016c2ede18841/docs/concepts/how-celestia-works/data-availability-layer.md?plain=1#L152

rootulp avatar Aug 30 '22 18:08 rootulp

apologies again for the delay on this, but I've removed all of my branches. There are still a few old ones that are not mine, but I don't feel comfortable deleting other people's branches.

some of them were quite nostalgic. I almost just want to keep them forever as graffiti on my own fork lol

evan-forbes avatar Sep 02 '22 04:09 evan-forbes

apologies again for the delay on this

No worries on the delay, this is a low priority chore.

I don't feel comfortable deleting other people's branches.

It seems possible to restore deleted branches so I'm comfortable doing this unless you object.

Ref: https://stackoverflow.com/questions/4674226/does-github-keep-deleted-remote-branches-in-history-if-so-can-those-be-restore

rootulp avatar Sep 02 '22 13:09 rootulp

Screen Shot 2022-09-14 at 10 28 57 AM

master has a branch protection rule that prevents me from deleting it

rootulp avatar Sep 14 '22 14:09 rootulp

I deleted branches that haven't been touched in over 6 months: https://github.com/celestiaorg/celestia-core/branches

We're down to 10 branches. Screen Shot 2022-09-22 at 10 50 08 AM

Tagging @evan-forbes if you have admin rights to delete the master branch.

rootulp avatar Sep 22 '22 14:09 rootulp

I'm opposed to deleting the master branch, as it has a lot of history for the work we did before we started the new approach of treating tendermint as a black box. Its likely not that useful, but perhaps we'll want to remember some weird thing that we did.

evan-forbes avatar Sep 22 '22 18:09 evan-forbes

If it's strictly for reference purposes, are you open to renaming master to deprecated-master in order to avoid confusion like https://github.com/celestiaorg/celestia-core/pull/795#pullrequestreview-1030657928

rootulp avatar Sep 22 '22 18:09 rootulp

updated

evan-forbes avatar Sep 23 '22 19:09 evan-forbes