ronso0

Results 1331 comments of ronso0

LGTM, but the indentations of the xml files are screwed up again. I think you need to adjust your editor to use spaces instead of tabs like in c++ code....

I can't confirm with any of the blinking modes, all blining stops as soon as tracks are ejected. Which mode did you use? Were you using a controller? FWIW [`CueControl::resetIndicators()`](https://github.com/mixxxdj/mixxx/blob/3c6e23fd8db91a5e967387eaf08dfa74519923cb/src/engine/controls/cuecontrol.cpp#L2183)...

Weird, that was the first mode I tested with. Still can't repro :man_shrugging: Linux amd64 with Qt 5.12.8 Can you check the log and run in --developer mode to check...

Maybe [mixxx-2.4.1-62-gd6f94236bd-macosarm.dmg](http://downloads.mixxx.org/snapshots/2.4/mixxx-2.4.1-62-gd6f94236bd-macosarm.dmg) from http://downloads.mixxx.org/snapshots/2.4/ ?

Thanks for the report! I can not confirm, neither by only opening the context menu, nor by doing some mass-edit (tested color, reset playcount, reset BPM). > Right click on...

Alright, thanks for taking the time. I could reproduce a few times (though not relaibly) with these steps: 1. track C selected 2. change the star rating of track A...

> I'll try to repro again with the ["selectedClick" switch](https://github.com/mixxxdj/mixxx/blob/400ae4618078fb07c063fceae3056253c6725d09/src/widget/wtracktableview.cpp#L111-L117) disabled. That workaround is unrelated, can now repro somewhat reliably with the steps from above. (and couldn't repro with 2.4.2...

Thanks! There are some pre-commit issues. FYI `print()` can be replaced with `console.log()` (just noticed this, not going to review the code)

I extended that to ignore Right key as suggested by @JoergAtGithub