ronso0
ronso0
Besides: thanks @ywwg for the quick fix, I didn't notice it's that easy. I think this is what I will use personally (FWIW building commit with ControllerManager is 1cebbb7eed) Also,...
> And even if we changed that and just logged a warning (which we shouldn't, because this really helps detecting mapping bugs), it would lead to weird behavior. Because if...
I was only referring to the current state of this PR: skin controls available for mappings -- no new features.
> so @ronso0 do you think we still need something like this now that #4661 is in? Yes, I'd appreciate this fix here. It's very simple and I don't spot...
_ping_ @ywwg
Code LGTM. If this wasn't yet tested with both legacy skins and QML I can test this with my controller tomorrow night, though only with legacy skins.
one aspect to consider for mappings: if longpress of `IN/4BEAT` should indeed always set a 4-beat loop (and not use the deck's individual beatloop size), the longpress duration should be...
> > the longpress duration should be adjusted > > Maybe there is a misunderstanding - the longpress emits another midi message. It is not something done in the mapping...
> I wonder if this can become the default behavior of "beatloop_activate" > > In case a user sets the loop_in position and presses "beatloop_activate" before the possible loop_out point...
> I don't think that this will interfere with any other workflow. The only situation I can imagine is * have an very high beatloop size, e.g. 128 * set...