ronso0

Results 1331 comments of ronso0

What's up with this PR? Looks like it's the same as #15146?

friendly ping @sdv0001 What's the purpose of this PR? It's named ..-test, is it just to run CI? If yes, you can also do that on your mixxx fork without...

> Looks like you forgot to commit the relevant parts, eg. GenreDAO and changes to TrackCollection? Oh, this is based on #15145? Please rebase onto https://github.com/sdv0001/mixxx/tree/feature/genre-dao so those commits are...

Please use compact commit message and move more info to the body https://github.com/mixxxdj/mixxx/wiki/Contribution%20Guidelines#all-contributors (first chapter / bullet list)

Currently WGenreTagInput writes genres directly to the track. This causes two issues: 1) it's bypassing Apply / Cancel of DlgTrackInfo 2) due to the `Track::changed` signal it causes a track...

I'd go with **1. generate from c++ code base** (though that's not trivial afaict) and maintain the manual by hand. Because **2. generate the controls documentation from TS types with...

> `type KnownSamplerControl = '[Sampler1]' | [Sampler2]' | [Sampler3]' | [Sampler4]'` Remember that we can have up to 64 samplers :grimacing:

Thank you for this PR! Unfortunately this branch doesn#t build. Please check the CI output for details, it's mostly typos an missing characters.

@audministrator This update has more debug logging and may also fix the offset issue for you. Please test and comment here. (note this does still act on QEvent::Show, but I'll...