Robert Nagy comments

Results 722 comments of


                                            Robert Nagy

Call flushSync if too much data buffered

I'm doing something like this atm: ``` stream = pino.destination({ sync: false, minLength: 4096 }) let flushing = 0 setInterval(() => { if (flushing > 8) { stream.flushSync() } else...

Call flushSync if too much data buffered

> Did you implement that workaround becaude you experienced some OOM crash? Correct.

Call flushSync if too much data buffered

I think we might need some more guidance in the docs around async mode and this. Not quite sure what that would be though.

Call flushSync if too much data buffered

Would it make sense to have a "maxLength" in addition to "minLength" which indicates an automatic flush?

shutdown error

Just regular stdout.

shutdown error

docker

shutdown error

I don't think it's the callback. That would not cause a shutdown error. I suspect fsync throws invalid arguments synchronously if fd is invalid. How fd can be invalid is...

use std::optional<std::string> over std::string*

@vweevers this won't work as prebuildify-cross will fail for std::optional.

raw mode?

> That makes nextv() slower because that must then "unflatten" the array in JS land. I was thinking that the flat array could go all the way to the user...

raw mode?

I'm currently working with `json` encoding. It's on my roadmap to eventually move to `string` and then `Buffer` but that adds significantly complexity so currently I'm trying to find simpler...