Robert Nagy comments

Results 722 comments of


                                            Robert Nagy

fix: remove npm

@darcyclarke or anyone else in favor of this PR. Could you please address the following objection: > ... it's a fairly clear statement that the current setup is satisfying enough...

fix: remove npm

Adding to tsc agenda due to the legal concerns raised.

peek

I don't see why whether it is time consuming or not is an issue as the predicate check could (should) be a asynchronous operation. In my use case the check...

Task Priorities?

I think this could easily be accomplished by grouping by state and then orderByPriority when fetching tasks.

Remove unnecessary flushing var

Re-run CI?

Remove unnecessary flushing var

weird

Remove unnecessary flushing var

seems to fail on node 12

flush semantics are unclear

I notice there is actually a todo for this already: ``` // TODO write all .buf ```

actualClose can close fd while writing

I think `actualClose` just needs a: ```js if (sonic._writing) { sonic.once('drain', actualClose.bind(null, sonic)) return } ```

actualClose can close fd while writing

> Did you see this happening? Nope. Just based on review of the code. These kind of undefined behaviors are very to actually notice in practice.