Robert Nagy comments

Results 722 comments of


                                            Robert Nagy

fix: use readable-stream

@mcollina yea, assuming I managed to fix that, do you have any further objections?

fix: use readable-stream

> I would prefer if you just used `node:stream` instead of depending on a npm package Why?

fix: use readable-stream

@mcollina wdyt?

fix: use readable-stream

Make sure we have the latest stream fixes even when not running latest version of Node. The same reason why readable-stream exists in the first place.

fix: use readable-stream

> * `node:stream` is always up to date with newest features This is a truth with modification. Only if/when you are running latest version of Node. Otherwise, the opposite should...

fix: use readable-stream

> I mostly saw it as "just to bring it outside of nodejs". all those legacy package never updated their own code after a while and those started to lack...

fix: use readable-stream

Would be nice if it only used the polyfills when required, i.e. running an older Node version than expected.

fix: use readable-stream

So it seems to me like this could be a good idea but would require some more things from readable-streams: - [ ] https://github.com/nodejs/readable-stream/issues/501 - [ ] Only install/use events...

fix(api-stream): Add throwOnError support in undici.stream

This will be fixed once we move `throwOnError` to an interceptor. https://github.com/nodejs/undici/issues/2835

Using async cache dedupe for http request caching

I think you can be more generic that `onResponse`, maybe `onResult`?