Robert Nagy comments

Results 722 comments of


                                            Robert Nagy

Undici builds in Node 20.3.0 are non-repeatable

SGTM!

feat: implement 0 dependency streaming multipart/form-data parser

@KhafraDev What's the status on this? Are we using file backed Blob?

feat: implement 0 dependency streaming multipart/form-data parser

@KhafraDev did you give up on this?

fetch: limit web streams usage in body mixin methods

I'm -1 for anything that goes against the spec without significant improvements.

fetch: limit web streams usage in body mixin methods

I'm not blocking. Just harder to maintain when the spec changes it wording. Then you have to reverse engineering back to the old wording.

fetch: limit web streams usage in body mixin methods

How about -0 then? 🙂

Undici's Fetch's Body takes a long time to load compared to just request

> ... and if we re-assign this.body to the result of pipeline, it fixes the issue, but causes issues with invalid gzipped/brotli compressed bodies. Not sure I follow.

Undici's Fetch's Body takes a long time to load compared to just request

I think it just removes the decompression...?

Undici's Fetch's Body takes a long time to load compared to just request

Webstreams...

Undici's Fetch's Body takes a long time to load compared to just request

Can be that web streams have smaller chunks which makes the decompression much less efficient... or something