Rom Grk

Results 558 comments of Rom Grk

I've added a section on ESM loader hooks. Can someone review & approve this PR?

> is useful to disambiguate it from the native React.useLayoutEffect We strictly enforce using React imports with `React.[...]` via an eslint rule, so it's always unambiguous that it's not the...

Code is read considerably more times than it is written, it feels preferable imo to optimize for readability rather than save 2 clicks when importing that hook.

We could also consider the shorter `useIsoLayoutEffect`, which makes it non-ambiguous where the function is coming from (the `use-isomorphic-layout-effect` package), though I still think `useLayoutEffect` is better. The "iso" or...

I strongly prefer `useLayoutEffect`, because I don't think the semantic brings anything useful. The difference is just about the warning message (AFAIK), and I don't think avoiding a warning message...

For your issue, I don't like adding an async delay there, even if just `1ms`. You should retrieve the buf/win ID during the event handler via the usual mechanism (``...

Code-wise the PR looks good, but I've been running it for a while and I keep seeing cases where the context window(s) don't get opened. It doesn't bother me much...

Not enough time to review/debug the few minor issues that appeared at the time. I'd be happy to see this feature, I just don't have much time to put into...

If you do the animation outside of React there shouldn't really be much of a perf cost to it (assuming you use [this lightweight `animate` function](https://gist.github.com/romgrk/0627faac9c6f810c28e0fc56efefd9a8)): ```diff diff --git a/packages/x-charts/src/Gauge/GaugeValueArc.tsx...

I'm precisely trying to use native DOM for virtualization, the example above is a completed exploration of a virtualization engine that uses the DOM directly. The problem is that we...