Rom Grk

icon indicating a website link romgrk.com

icon location Montreal,QC icon location C/C++, Rust, Typescript, vim & dharma

Results 558 comments of Rom Grk

[DataGrid] Spread forwardedProps onto grid element

But it could also be a different prop like `forwardedPropsGrid`. Is there a use-case for both?

[DataGrid] Spread forwardedProps onto grid element

I'm fine with that.

[DataGrid] Spread forwardedProps onto grid element

I would favor adding `forwardedPropsGrid` instead of `forwardedPropsV8`, even if we're going to rename/remove them later.

[data grid] Overlays aren't sticky in RTL mode

I'm not sure, but I would expect this to be fixable with just CSS.

[data grid] Overlays aren't sticky in RTL mode

The issue seems fixed on some platforms and still present in others (macOS at least).

[perf] WASM hashing function

For more precise numbers, XXH is 519 bytes of binary, and murmur2 is 386 bytes of binary, so total 800 and 650 after wrapping & base64 is a good figure.

[perf] WASM hashing function

I have improvements for the JS implementation but I have split them in #3242.

[perf] WASM hashing function

The performance numbers are all in the [top comment of that PR](https://github.com/emotion-js/emotion/pull/3242#issue-2477445585), but roughly 2x faster than the improved javascript implementation, which is itself roughly 2x faster than the current...

[perf] WASM hashing function

I've found a [performant port of xxh](https://github.com/cgiosy/xxh32/blob/main/src/index.ts) but it can't beat murmur2 in javascript: ``` Running "Benchmark hash, string length = 1245" suite... murmur2_original(): 1 258 ops/s, ±0.53% | slowest,...

[perf] WASM hashing function

Follow-up of @emmatown [comment](https://github.com/emotion-js/emotion/pull/3242/files#r1728067503) in the other PR, the algo needs to be stable in case of server-rendering hydration, which means either murmur2 or xxh in both versions. You have...