Rom Grk comments

Results 558 comments of


                                            Rom Grk

[DataGrid] Fix column resize not working with special character

@cherniavskii I'll let you approve & merge.

[DataGrid] Fix column resize not working with special character

@oukunan Could you merge master in this branch? That should fix the tests.

[DataGrid] Fix column resize not working with special character

Thanks for the PR!

[data grid] Unexpected cell text selection highlighting area in v7 in Chromium Browsers

The change in cell structure is similar to what other grid components have. I have inspected a bit what the other components are doing to deal with text selection: most...

[data grid] Unexpected cell text selection highlighting area in v7 in Chromium Browsers

But other grids are also having the same behavior: https://ag-grid.com/react-data-grid/selection-overview/#cell-text-selection It would be possible for users to re-add a wrapper using `renderCell`, but that has performance implications in particular for...

[data grid] AXE test fails due to invalid child role "presentation"

I don't think role=presentation is the problem, from the spec: > The intended use is when an element is used to change the look of the page but does not...

[data grid] AXE test fails due to invalid child role "presentation"

Thanks. We receive reports from time to time from various ARIA checkers and they're not always accurate or consistent with one another, if we could have more clarity onto what...

[data grid] AXE test fails due to invalid child role "presentation"

Note that this issue is still present for firefox, the `tabIndex=-1` is a workaround for a firefox issue.

[data grid] AXE test fails due to invalid child role "presentation"

No, will be released this week.

[data grid] detail panel + sortModel causes "Maximum call stack size exceeded"

I have added the tag for the other issue, let's discuss there.